Swift 2.2 #18
Closed
Swift 2.2 #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinpawela
pushed a commit
that referenced
this pull request
Apr 2, 2016
| func addData(data: NSData) { | ||
| dispatch_async(self.lock, { | ||
| let id = ++self.currentMaxID | ||
| let id: UInt = UInt(self.currentMaxID += 1) |
There was a problem hiding this comment.
@JackoPlane
I updated this while merging your PR, but I wanted to point out that your update in this instance was not quite right.
UInt(self.currentMaxID += 1) always evaluates to 0, because the expression self.currentMaxID += 1 does not return anything -- or more accurately, returns () -- and UInt(()) evaluates to 0. Thus id would always be 0, even while currentMaxID is being incremented, which is not what we want!
Anyway, I updated it while merging to correct the behavior. Otherwise, thanks for the PR!
There was a problem hiding this comment.
Gah! Nice catch @justinpawela! Thanks for merging so quickly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.