FYI: there will be notice, alert and maybe other cases.

Kay, I went ahead and cleaned up the way we do flash messages, which was decently bad and is now pretty good.

Defines four levels:

FlashService.success
FlashService.info
FlashService.warning
FlashService.error

Which accepts a translation value and translation options (or just a simple string to display, in the case of symbols or things already translated on the server side)

I also switched it to a $broadcast / $on system, which is more reliable I think and more consistent with the way we do things in the rest of the app.

🔦!

Yeah! I tried putting it there, but had that code run before the
$scope.$on 'flashMessage' event had been defined, so it didn't catch it.
Wonder if there's a better place, or a way to switch up the order in which
things get loaded?

On Thu, Apr 9, 2015 at 4:10 AM, Robert Guthrie [email protected]
wrote:

Merged #2091 #2091.

—
Reply to this email directly or view it on GitHub
#2091 (comment).