Update iframe-resizer to v5.x [LICENSE INCOMPATIBLE]#753
Open
allmarkedup wants to merge 1 commit intomainfrom
Open
Update iframe-resizer to v5.x [LICENSE INCOMPATIBLE]#753allmarkedup wants to merge 1 commit intomainfrom
allmarkedup wants to merge 1 commit intomainfrom
Conversation
✅ Deploy Preview for lookbook-docs canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the iframe-resizer package to
v5.xto get rid of the console log pollution described in #752.However... it seems that as part of the v5 release the
iframe-resizerpackage was re-licensed and is now distributed under the GPLv3 (for open source use). My understanding is that if Lookbook includes a GPLv3-licensed dependency such as this it would mean that any apps that use it would also be required to be GPL-compatible (or would be obligated to buy an iframe-resizer license themselves).Many companies that use Lookbook have closed-source apps - Lookbook is intentionally MIT-licensed to permit that usage - and so are not GPL-compatible. We obviously can't require Lookbook users to buy an
iframe-resizerlicense in order to legally use it within their apps so it looks like we'll have to stay on the v4.x branch (which is MIT-licensed) 😞This is very far outside my area of expertise so if I've misunderstood the implications of the license change at all or anyone knows of a way to upgrade this dependency in a licence-compatible way then please let me know.