This repository was archived by the owner on Sep 30, 2025. It is now read-only.
Jamesmoore/arch 354 add option to disable volatilitymonitor in silo #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jimmy Moore <[email protected]>
Signed-off-by: Jimmy Moore <[email protected]>
Signed-off-by: Jimmy Moore <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to disable VolatilityMonitor per device, which can reduce CPU usage.
VolatilityMonitors purpose is to monitor the writes on a per block basis, and then when a migration happens, it is able to send blocks in the best order - from least volatile to most volatile. This reduces the amount of dirty blocks, and reduces the data transfer when we are doing dirty loops.
However, if we just want to 'evacuate' quickly, rather than minimizing downtime, there is no benefit to using volatilityMonitor, and it just increases CPU load.
The PR adds a new device config which can be used in the future to hold any other migration type options. This starts with the bool "AnyOrder". If set to true, then VolatilityMonitor will not be used for the device.