Cland: Hold Points: Init meta battle_stat, form #2146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
alek13
reviewed
Apr 7, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
2b1d20e to
0be09df
Compare
alek13
requested changes
Apr 28, 2025
Member
alek13
left a comment
There was a problem hiding this comment.
Хорошие подвижки.
С коммитами беда: в них нет ссылок на задачи, они не говорят что было добавлено человеко-понятным языком.
Напомню: сообщения коммитов уходят:
- в список на тестирование
- в чендж-лог релиза для прочтения игроками
alek13
requested changes
Apr 29, 2025
alek13
reviewed
Apr 29, 2025
alek13
reviewed
Apr 29, 2025
alek13
reviewed
Apr 29, 2025
alek13
reviewed
Apr 29, 2025
alek13
requested changes
Apr 29, 2025
Member
alek13
left a comment
There was a problem hiding this comment.
LGTM; пара код-стайлов и начисление первоначальных очков
…rver#2126 Add form with classes Rewrote `on_punch`, added `on_place` checks Rewrote iteration of the 'battle-stat' table Added checks for empty player or clan values Prohibited node installation for players without server privilege Ran it through a bot to simplify the code
49bb9b6 to
24ffb1a
Compare
alek13
requested changes
May 6, 2025
alek13
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание PR:
Дополнил метаданные таблицей
battle_statДля теста: при ударе по ноде в таблицу пишется клан и время удара
В рабочей версии: в таблицу будут записываться баллы
Добавил начальную форму для смены имени ноды
Рекомендации к тесту:
Уронить сервер формой или использованием ноды
Получить привилегии при установке или использовании ноды
Дополнительная информация:
Closes #2125
Closes #2126