Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added christmas skin to reward_chest. LG-2039 #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alek13 merged 3 commits into from
Dec 21, 2025
Merged

Added christmas skin to reward_chest. LG-2039 #2339

alek13 merged 3 commits into from
Dec 21, 2025

Conversation

@blanka-kato
Copy link
Contributor

@blanka-kato blanka-kato commented Dec 17, 2025

Описание PR:

Добавил заснеженный скин для праздничного сундука с наградой
Заменил функцию подмены скина с Хэллоуина, на Рождество
Прописал даты ивента от 18 декабря до 14 января

Рекомендации к тесту:

Проверить, что скин сменился и сундук с наградами выглядит вот так
изображение

@blanka-kato blanka-kato requested a review from alek13 December 17, 2025 19:36
@blanka-kato blanka-kato self-assigned this Dec 17, 2025
alek13
alek13 requested changes Dec 18, 2025
View reviewed changes
@alek13
Copy link
Member

alek13 commented Dec 18, 2025

PS:

у нас в _overwrites лежат картинки:

  • mods/lord/_overwrites/lord/lord_money/textures/_NY-shop_chest_top.png
  • mods/lord/_overwrites/MTG/default/textures/_NY-default_chest_front.png
  • mods/lord/_overwrites/MTG/default/textures/_NY-default_chest_inside.png
  • mods/lord/_overwrites/MTG/default/textures/_NY-default_chest_lock.png
  • mods/lord/_overwrites/MTG/default/textures/_NY-default_chest_side.png
  • mods/lord/_overwrites/MTG/default/textures/_NY-default_chest_top.png

это легаси расположение, т.к. у нас появился mods/lord/Blocks/Holidays.
забери, плиз, эти картинки тоже в новый мод.

давай, наверное, назовём мод new_year (а не christmas) -- всё-таки это ближе к русской душе :)

@blanka-kato blanka-kato reopened this Dec 20, 2025
alek13
alek13 reviewed Dec 20, 2025
View reviewed changes
@blanka-kato blanka-kato force-pushed the christmas_skin_for_quest_chest branch 2 times, most recently from 6cf0eeb to bf6cf64 Compare December 21, 2025 18:18
alek13
alek13 previously approved these changes Dec 21, 2025
View reviewed changes
@blanka-kato blanka-kato force-pushed the christmas_skin_for_quest_chest branch 2 times, most recently from 21924fb to fc62606 Compare December 21, 2025 18:40
@blanka-kato
Fix cyclomatic complexity
afa8b73 
Move christmas texures to new_year mode
@blanka-kato blanka-kato force-pushed the christmas_skin_for_quest_chest branch from fc62606 to afa8b73 Compare December 21, 2025 18:40
@alek13 alek13 merged commit 7eaae2e into lord-server:dev Dec 21, 2025
2 checks passed
@blanka-kato blanka-kato deleted the christmas_skin_for_quest_chest branch December 21, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alek13 alek13 alek13 approved these changes

Assignees

@blanka-kato blanka-kato

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blanka-kato @alek13