Fix: link uninstall deletes non-symlinked local files #2112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file exists Fixes #2111
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a critical bug where link_uninstall would delete non-symlinked files from the user's home directory. The fix adds validation to ensure only proper Mackup symbolic links are processed during uninstall.
- Added safety check to verify Mackup files are valid symlinks pointing to the correct home file
- Added three comprehensive test cases covering non-symlink files, wrong-target symlinks, and correct symlinks
- Warning message now displayed when skipping invalid symlink configurations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| mackup/application.py | Added validation to check if Mackup file is a symlink pointing to the expected home file before proceeding with uninstall |
| tests/test_application.py | Added three test cases to verify the new safety behavior for different symlink scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness of the
link_uninstallmethod inmackup/application.pyby ensuring it only processes Mackup files that are valid symbolic links pointing to the correct home file. It also adds comprehensive tests to verify the new behavior, including handling cases where the Mackup file is not a symlink or points to the wrong target.Robustness and correctness improvements
link_uninstallmethod to skip and warn when a Mackup file is not a symbolic link or does not point to the expected home file, preventing unintended file operations.Test coverage enhancements
test_link_uninstall_mackup_not_a_linkto verify that non-symlink Mackup files are skipped and a warning is printed.test_link_uninstall_mackup_points_to_wrong_targetto check that symlinks pointing to the wrong target are also skipped with a warning.test_link_uninstall_mackup_points_correctlyto confirm that normal operation proceeds when the symlink points to the correct home file.Fixes #2111