Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support for arrays of extern instances #5338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2025
Merged

Support for arrays of extern instances #5338

merged 1 commit into from
Sep 30, 2025

Conversation

@ChrisDodd
Copy link
Contributor

@ChrisDodd ChrisDodd commented Jul 1, 2025

Extending array support to allow arrays of extern instances.

@ChrisDodd ChrisDodd force-pushed the cdodd-externarray branch from 603b698 to 764e40f Compare July 1, 2025 23:32
@ChrisDodd ChrisDodd requested review from asl and fruffy July 2, 2025 22:02
@fruffy fruffy added the core Topics concerning the core segments of the compiler (frontend, midend, parser) label Jul 4, 2025
@fruffy
Copy link
Collaborator

fruffy commented Jul 4, 2025

I haven't kept track, is this something that is already part of the spec or do we have a related spec issue? Is this an alternative solution to #5330?

@ChrisDodd
Copy link
Contributor Author

ChrisDodd commented Jul 5, 2025 •
edited
Loading

The array change to the spec has not yet been pulled in (p4lang/p4-spec#1360), but it includes an allowance for arrays of extern instances (for architectures that want to support it). This is orthogonal to #5330, though necessary to support an alternative using (arrays of) externs with implicit read/assign methods. (so in that sense it is an alternative)

@ChrisDodd ChrisDodd force-pushed the cdodd-externarray branch from 764e40f to 1dad839 Compare July 6, 2025 05:20
@ChrisDodd ChrisDodd mentioned this pull request Jul 6, 2025
Draft
@ChrisDodd ChrisDodd force-pushed the cdodd-externarray branch from 1dad839 to eedb020 Compare July 22, 2025 00:40
@ChrisDodd
Copy link
Contributor Author

ChrisDodd commented Jul 23, 2025

@jafingerhut @vgurevich @fruffy @asl Anyone have any further comments on this? Any objections?

@ChrisDodd ChrisDodd mentioned this pull request Aug 3, 2025
Merged
@ChrisDodd ChrisDodd force-pushed the cdodd-externarray branch 2 times, most recently from 6970e59 to 3c2ad82 Compare August 11, 2025 22:02
@ChrisDodd
Copy link
Contributor Author

ChrisDodd commented Sep 29, 2025

@fruffy @jafingerhut @jonathan-dilorenzo This PR has now been hanging out waiting for approval for 3 months. Per discussions in the LDWG it would seem to be ok.

@fruffy
Copy link
Collaborator

fruffy commented Sep 30, 2025

Approving since there have not been any objections within this time frame.

@ChrisDodd ChrisDodd added this pull request to the merge queue Sep 30, 2025
Merged via the queue into p4lang:main with commit 9d17f37 Sep 30, 2025
18 of 19 checks passed
@ChrisDodd ChrisDodd deleted the cdodd-externarray branch September 30, 2025 16:33
@kfcripps kfcripps mentioned this pull request Oct 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fruffy fruffy fruffy approved these changes

@asl asl Awaiting requested review from asl

@jonathan-dilorenzo jonathan-dilorenzo Awaiting requested review from jonathan-dilorenzo

Assignees

No one assigned

Labels

core Topics concerning the core segments of the compiler (frontend, midend, parser)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ChrisDodd @fruffy