Fix type unification bug with `int' args #5346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca81e1a to
eb0b0cc
Compare
- when a method is unified multiple times (for mulitple call sites), we need fresh TypeVars for each arg's type. The function to do this (cloneWithFreshTypeVariables) was not properly creating fresh Type_InfInt nodes, leading to problems if the method was called in multiple places with different types. Signed-off-by: Chris Dodd <[email protected]>
asl
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a method is unified multiple times (for mulitple call sites), we need fresh TypeVars for each arg's type. The function to do this (cloneWithFreshTypeVariables) was not properly creating fresh Type_InfInt nodes, leading to problems if the method was called in multiple places with different types.