ensure child of IR::SwitchCase remains a BlockStatement #5349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
661ba1f to
e3ab1c5
Compare
ede08a1 to
72721ae
Compare
72721ae to
ac17660
Compare
Various transforms replace statements with other statements, often using inlineBlock to properly inline into a containing block. It turns out when returning a single (non-block) statement, it still needs to be wrapped in a BlockStatement if the parent is a SwitchCase. Signed-off-by: Chris Dodd <[email protected]>
Contributor
Author
|
@asl @vlstill @fruffy This is a fairly striaght-forward bug fix with no effect on the language. The only reason the restriction in the IR is relevant is that the language requires explicit |
fruffy
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various transforms replace statements with other statements, often using inlineBlock to properly inline into a containing block. It turns out when returning a single (non-block) statement, it still needs to be wrapped in a BlockStatement if the parent is a SwitchCase.