You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following code will print warnings for each e in modifies in a non-deterministic order:
for (auto p : *mi->substitution.getParametersInArgumentOrder()) {
if (useTemporary.find(p) != useTemporary.end()) continue;
auto arg = mi->substitution.lookup(p);
if (typeMap->isCompileTimeConstant(arg->expression)) continue;
for (auto e : modifies) {
// Here we use just raw equality: equivalent but not equal expressions
// should be compared.
if (e != arg->expression && mayAlias(arg->expression, e, getContext())) {
LOG3("Using temporary for " << dbp(mce) << " param " << dbp(p) << " aliasing"
<< dbp(e));
if (p->hasOut())
warn(ErrorType::WARN_ORDERING,
"%1%: 'out' argument has fields in common with %2%", arg, e);
useTemporary.emplace(p);
break;
}
}
}
@ChrisDodd That would ensure that the modifies iteration order is identical to modifies insertion order. But modifies insertion order would still not be stable, right (as gwe.written insertion and iteration order would still not be identical)?
@ChrisDodd That would ensure that the modifies iteration order is identical to modifies insertion order. But modifies insertion order would still not be stable, right (as gwe.written insertion and iteration order would still not be identical)?
modifies is built in order from substitution.getParametersInArgumentOrder, so should be deterministic (in order of the arguments to resolved method call).
coreTopics concerning the core segments of the compiler (frontend, midend, parser)
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following code will print warnings for each
einmodifiesin a non-deterministic order: