-
Notifications
You must be signed in to change notification settings - Fork 472
Small build cleanups #5388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small build cleanups #5388
Conversation
chreekat
commented
Sep 18, 2025
- Remove reference to nonexistent matrix vars
- Remove reference to nonexistent submodules
Signed-off-by: Bryan Richter <[email protected]>
Signed-off-by: Bryan Richter <[email protected]>
|
Looks like the x86 mac-os build is failing because of an outdated MacOS version. |
|
Yeah, looks like it went out of date precisely 4 days ago, and homebrew is not gonna take any shit about it. I guess it would be kind of nice to still have one test on the pre-Arm architecture, so I'll see if there's a flag I can pass to disable the hard error. But maybe we should just go ahead and step to macos14 and 15 instead of 13 and 14. |
|
Ah, maybe you can still get non-Arm on later versions. At any rate, I'll simply upgrade, since the alternatives look bad. |
Upgrading sounds good. |
|
We can stick with macos-latest and drop the matrix for 14. It looks like the x86 builds are being deprecated in Github actions support: https://docs.github.com/en/actions/how-tos/write-workflows/choose-where-workflows-run/choose-the-runner-for-a-job#standard-github-hosted-runners-for-public-repositories I will update the Github required actions once the yaml is updated. |
Just run one job on the latest available OS. Signed-off-by: Bryan Richter <[email protected]>
c0a3610 to
e2fb6cb
Compare