[fix] reporting error messages from uclid when base case failed verification #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves error reporting from Uclid when base case verification fails and fixes the proof of the Ring Leader Election (RLE) protocol. The changes enhance debugging capabilities by providing clearer error messages and restructure the verification approach using proper lemmas and theorems.
- Simplifies error message formatting by removing redundant step indicators
- Adds informative comments to generated invariants for better debugging
- Restructures RLE protocol verification using proper lemma/theorem hierarchy
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Src/PCompiler/CompilerCore/Backend/PVerifier/Uclid5CodeGenerator.cs | Improves error message reporting by removing step indicators and adding descriptive comments to invariants |
| Tutorial/Advanced/3_RingLeaderVerification/PSrc/System.p | Restructures verification using init-conditions, lemmas, and theorems instead of axioms |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
ankushdesai
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proof of RLE protocol is also fixed in this PR.