Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WRAPPER] Fixed stack align on varargs (for #789) #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ptitSeb merged 1 commit into from
May 16, 2023
Merged

[WRAPPER] Fixed stack align on varargs (for #789) #790

ptitSeb merged 1 commit into from
May 16, 2023

Conversation

@ksco
Copy link
Collaborator

@ksco ksco commented May 16, 2023

Closes #789

@ptitSeb
Copy link
Owner

ptitSeb commented May 16, 2023

It broke one test on riscv it seems

@ksco
Copy link
Collaborator Author

ksco commented May 16, 2023

Hmm, I got a bit confused about this, looks right this time.

ptitSeb
ptitSeb reviewed May 16, 2023
View reviewed changes
src/include/myalign.h Outdated

#elif defined(__loongarch64) || defined(__powerpc64__) || defined(__riscv)
#undef X64_VA_MAX_XMM
#define X64_VA_MAX_XMM ((6*8)+(8*8))
Copy link
Owner

@ptitSeb ptitSeb May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm, no, you shouldn't change this variable just for some arch, as it's an x86 one, so it should be common for every arch

Copy link
Collaborator Author

@ksco ksco May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reg_save_area seems always 8 bytes wide, no matter what type.

Copy link
Collaborator Author

@ksco ksco May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reg_save_area seems always 8 bytes wide, no matter what type.

@ptitSeb
Copy link
Owner

ptitSeb commented May 16, 2023

I'm pretty sure (6 * 8 + 8 * 16) is the right value

@ptitSeb
Copy link
Owner

ptitSeb commented May 16, 2023

I think your 1st attempt was correct, with just 1 mystake: you should keep area[fprs/8]because area is a uintptr_t array, and so elements are 8-bytes in size, not 16 bytes (we don't take the whole XMM regs, just a double)

@ksco
Copy link
Collaborator Author

ksco commented May 16, 2023

Oh yes, that's right. I got confused on the area and fp_offset, they're inconsistent in this situation.

@ptitSeb ptitSeb merged commit d61f3e7 into ptitSeb:main May 16, 2023
@ksco ksco deleted the fix branch May 16, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ptitSeb ptitSeb ptitSeb left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Running VS Code on RISC-V SBC

2 participants

@ksco @ptitSeb