[RV64_DYNAREC] Added movbe opcode #926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xctan
reviewed
Aug 8, 2023
| // put imm20 in the [31:12] bits of rd, zero [11:0] and sign extend bits31 | ||
| #define LUI(rd, imm20) EMIT(U_type((imm20)<<12, rd, 0b0110111)) | ||
|
|
||
| #define LI(rd, imm12) if (imm12 < 0x800) { ADDI(rd, xZR, imm12);} else {LUI(rd, 1); ADDIW(rd, rd, -(0x1000 - imm12));} |
Contributor
There was a problem hiding this comment.
This is redundant. FYI we have this macro, which correctly handles signed 32-bit immediate:
box64/src/dynarec/rv64/rv64_emitter.h
Line 114 in adaafc2
Contributor
Author
There was a problem hiding this comment.
You're right, I got a mistake. The immediate value for the pseudo instruction 'li' should be 32 bits.
Collaborator
There was a problem hiding this comment.
@wannacu Can you submit another PR for these suggestions?
xctan
reviewed
Aug 8, 2023
| } | ||
| } else { | ||
| if (rex.w) { | ||
| LI(x2, 0xff); |
Contributor
There was a problem hiding this comment.
0xff fits in imm12, so ADDI(x2, xZr, 0xff) is enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.