[RV64_DYNAREC] Added more support for XTheadBb extension #989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ksco
commented
Sep 24, 2023
- Added more support for XTheadBb extension
- Added a test for bswap and movbe
- Reformatted the code this PR touches, please ignore commits named "Reformat" when reviewing.
Owner
|
Something looks wrong, either with test24 or how movbe is handled in arm64, rv64 and interpreter! |
Collaborator
Author
|
Interesting, let me take a look. |
Collaborator
Author
|
It's the interpreter! MOVBE is operating on GPRs, not XMMs. |
Owner
|
Ah nice. And the ARM64 implementation seems wrong too :'( |
Collaborator
Author
|
One test catches all three :) |
Collaborator
Author
|
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.