[BUNDLE] Check for broken symlinks #2829
Conversation
to prevent issues such as ptitSeb#2825
|
For testing purposes, I temporarily reverted b1613be and verified that this new code was triggered. |
| if find "${dir_tmp_local}"/bundle-libs/ -type l ! -exec test -e {} \; -print | grep bundle-libs | ||
| then echo "Broken symlinks found." | ||
| cd - | ||
| echo rm -r -f "${dir_tmp_local}" |
There was a problem hiding this comment.
I am not comfortable with this. why testing the presence of "${dir_tmp_local}"/bundle-libs/ to then delete parent "${dir_tmp_local}"
What happens if "${dir_tmp_local}" is nothing or / for some reason? or even /tmp? That foldr should not be deleted.
There was a problem hiding this comment.
I already do the same kind of deletion at the very end:
https://github.com/ptitSeb/box64/blob/v0.3.6/box64-bundle-x86-libs.sh#L96
This test lists out every file that has a broken symlink. We're basically aborting early if there are.
We set the ${dir_tmp_local} variable here:
https://github.com/ptitSeb/box64/blob/v0.3.6/box64-bundle-x86-libs.sh#L35
I suppose there could be an edge-case where mktemp is not available (although, the supported platforms for running this script - Arch Linux, Debian, and Fedora - all have this installed by default). When testing this PR, I did test with an empty ${dir_tmp_local} and rm -r -f did nothing.
to prevent issues such as #2825