Add preserve-config flag to destroy #20815
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashish111333 <[email protected]>
|
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
Frassle
reviewed
Oct 27, 2025
Member
Frassle
left a comment
There was a problem hiding this comment.
This needs a quick test, probably in tests/smoke/smoke_test.go but otherwise seems simple enough
Contributor
Author
|
AR will add test. |
sprasad796
reviewed
Oct 28, 2025
| } | ||
|
|
||
| if preserveConfig { | ||
| fmt.Printf("The resources in the stack have been deleted, and history is removed.\n") |
There was a problem hiding this comment.
and preserve Pulumi-{stack}.yml config file. We usually display further option to user with destroy command to how to further get rid of the config file.
sprasad796
reviewed
Oct 28, 2025
| &remove, "remove", false, | ||
| "Remove the stack and its config file after all resources in the stack have been deleted") | ||
| cmd.PersistentFlags().BoolVar(&preserveConfig, "preserve-config", false, | ||
| "preserves the stack config file") |
justinvp
reviewed
Oct 28, 2025
| &remove, "remove", false, | ||
| "Remove the stack and its config file after all resources in the stack have been deleted") | ||
| cmd.PersistentFlags().BoolVar(&preserveConfig, "preserve-config", false, | ||
| "preserves the stack config file") |
Member
There was a problem hiding this comment.
Suggested change
| "preserves the stack config file") | |
| "Preserve the stack config file") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a preserve config flag to destroy Cmd now config is intact on
pulumi destroy --remove --preserve-config.closes #15069