patch_list: compact the from/to assembly display#1884
Merged
disconnect3d merged 2 commits intodevfrom Aug 23, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1884 +/- ##
==========================================
- Coverage 60.52% 58.62% -1.91%
==========================================
Files 180 180
Lines 22049 22049
Branches 2033 2033
==========================================
- Hits 13346 12927 -419
- Misses 8033 8487 +454
+ Partials 670 635 -35
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
I still feel sth is wrong with the 'from' assembly, why isn't it showing the same instruction as disassembled by GDB? Is the arch set properly? To be investigated.
Anyway, the compact enhancement is needed.