-
Notifications
You must be signed in to change notification settings - Fork 43
ENH: Add get / set precision ufuncs #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jorisvandenbossche
merged 11 commits into
pygeos:master
from
brendan-ward:set_precision
Jan 14, 2021
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0f68053
Add get / set precision
brendan-ward 5fcacfe
Add changelog entry
brendan-ward f5c14a8
Ensure only available for GEOS >= 3.6
brendan-ward fd82382
Remove keep_collapsed
brendan-ward d48dc68
Add test of intersection operation with precision set
brendan-ward 8f8670d
Add example of removing duplicated vertices
brendan-ward 87acb1d
Merge remote-tracking branch 'upstream/master' into set_precision
brendan-ward b922e60
PR feedback
brendan-ward d59cf40
PR feedback
brendan-ward 13e753e
Merge branch 'master' into set_precision
brendan-ward ed9a1eb
minor edits + limit line length in docstring
jorisvandenbossche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This behavior does not match what is described in the docstring "If 0, will use floating point precision."
If floating point precision (1E-7 for single or 1E-14 for double) would have been used, the two equal points would be merged into one.
I think the docstring needs adjustment: 0 means, do not change the geometry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is a bit more general than that; if you provide a more precise grid size than the grid size previously assigned to the geometry, the geometry should not be modified. This could happen if you first set a precision of 1, then set 0.1.
I'll try to make this more clear in the docstring.