Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@almarklein
Copy link
Member

@almarklein almarklein commented Mar 18, 2025

Closes #1045

While debugging I cleaned a few things up.

  • The actual fix is adding stub padding variables to the influences buffer.
  • Fix a case where a template var (use_morph_targets) was meant to store a bool, but ended up storing a tuple of arrays, which then participate to the shader's hash.
  • The morph count is the minimum of the lengths of the different morph arrays, similar to how Python's zip iterates up to the smallest size.
  • Use an explicit size for the influences buffer.
  • Use the actual max texture size.

cc @panxinmiao

@almarklein almarklein requested a review from Korijn as a code owner March 18, 2025 10:41
@Korijn Korijn merged commit 6b0a992 into main Mar 18, 2025
14 checks passed
@Korijn Korijn deleted the morph-fix branch March 18, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mesh morphing is broken on MacOS

4 participants