Instanced lines #1058
Merged
Instanced lines #1058
+73
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f7d0ffa to
551c4b4
Compare
almarklein
reviewed
Mar 28, 2025
almarklein
reviewed
Mar 28, 2025
551c4b4 to
5f7fe34
Compare
Member
|
The liter complaints. We use ruff for linting (
|
added 5 commits
March 31, 2025 16:16
5f7fe34 to
e020d80
Compare
Korijn
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces instanced line rendering:
InstancedMesh(Mesh)toInstancedObject(WorldObject)(no real changes) and refactorInstancedMeshto inherit fromMeshandInstancedObjectInstancedLineclass inheriting fromLineandInstancedObjectLineShader(copied the relevant parts fromMeshShader)line.wgsl(copied the relevant parts frommesh.wgsl)The duplications in the shader classes and shader code can probably be generalized to some degree as well, but I am not familiar enough with the templating engine to know how to do that.
Requires #1057 because the multiple inheritance breaks the pick info even more.