Add "KHR_materials_unlit" support #1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Currently, in the example, canceling IBL lighting will throw an exception, See #1005. |
Member
Is this a new error, or simply this use-case exposing it? In other words, do you want to merge this, or get #1005 fixed first? |
Contributor
Author
Contributor
Author
|
I was planning to fix the bug in #1005 while I was at it, but I found that it seems to be a bit tricky. 😓 |
Korijn
approved these changes
Feb 28, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support KHR_materials_unlit
This extension defines an unlit shading model for use in glTF 2.0 materials, as an alternative to the Physically Based Rendering (PBR) shading models provided by the core specification.
It is very useful in situations where resources are limited for mobile devices or stylized materials that do not require lighting (such as "anime" or "hand drawn" appearances).
For Pygfx, it basically corresponds to our MeshBasicMaterial.
This example demonstrates the differences in rendering the same model using unlit and standard PBR, with unlit material on the left unaffected by lighting and PBR material on the right affected by lighting.