Use single buffer to store per-glyph data #1010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We have definitely been feeling the effects of multiple calls to send data to the GPU!!!! Thanks for caring about this kind of optimization while everything is fresh in the mind! |
Korijn
approved these changes
Mar 3, 2025
Contributor
|
I'm pretty sure this broke text_waterfall.py |
Member
Author
|
Lol, we found out at the same time. I'm looking into #1001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the text geometry to use a single buffer for per-glyph data, instead of 4 separate buffers. This makes the code cleaner, and easier to add more data if we want later. It's also faster on the CPU side, because only one call to
.update_indices()instead of 4. And possibly faster on the GPU (could not measure that effect though).