No blending needed for opaque #1241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It's strange that the difference in screentshot has disappeared, 😓 |
almarklein
approved these changes
Nov 18, 2025
Korijn
approved these changes
Nov 18, 2025
Contributor
Author
|
Ah, the screenshot discrepancy has appeared again. It seems unrelated to the changes in this commit — there must be some unknown factor causing the CI screenshots to occasionally show slight differences. |
hmaarrfk
reviewed
Nov 18, 2025
Member
Yeah, still seems to glitch sometimes. I checked the diff screenshots last week or so. They had pixels being different in arbitrary places, so hard to pinpoint what's going on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For opaque objects, the rendering pipeline does not need to enable any blending operations—simply writing the pixel values directly into the buffer is sufficient. This helps improve performance.
This change was originally included in #974, but it seems introduced slight screenshot differences in the CI results, and it was not directly related to the main topic of that PR. To clearly distinguish these differences from those potentially caused by #974 itself, I separated this into an independent PR.