-
-
Notifications
You must be signed in to change notification settings - Fork 64
Refactor environment and pipeline #912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
almarklein
commented
Jan 14, 2025
Collaborator
Funny! I ran into exactly the same issue with #911 :) |
Contributor
|
Thank you releasing 0.7.0 before this refactor! |
Korijn
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the internals of the rendering engine, mainly the
environment.pyand thepipeline.py, mainly affecting how cache invalidation works.The main purpose is to make it possible to use multiple different
blend_modesettings in a single draw. This is a requirement for #492 e.g. to better support overlays.For renderstate:
environmenttorenderstate.WeakValueDictionary.For
pipeline.py:WeakAssociativeContainerto bind something to the lifetime of multiple objects at the same time.WeakAssociativeContainerto store pipeline-container-group objects on wobject+renderstate.PipelineContainerobjects are now simpler because there is one for each specific wobject-renderstate combination, instead of having to manage differerent render states.