Refactor the plugin extension mechanism of the glTF loader #940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Korijn
approved these changes
Jan 19, 2025
Collaborator
Korijn
left a comment
There was a problem hiding this comment.
Very nice work. :) Looking forward to seeing more GLTF compatibility!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the plugin extension mechanism of the glTF loader to make it easier to add more extensions support in the future.
Each glTF extension is now implemented as a plugin class that handles the corresponding logic and is registered with the glTF Loader. This way, when adding new glTF extension support, we only need to add a new plugin class.
Currently supported/implemented: