Provide a path for end users to register their own blenders #966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almarklein
reviewed
Feb 7, 2025
Member
almarklein
left a comment
There was a problem hiding this comment.
I think this can work as an experimental feature, and we can refine it (i.e. document what a blender should look like) after the upcoming refactoring.
hmaarrfk
commented
Feb 7, 2025
The ability to register blenders would remove a big 'non sactioned' customizations I have for PyGFX. It would also allow more end user blender modes. I know the blenders/rendering pipeline is being refactored. But this would really help in the meantime (after release 0.8.0 of course). Thanks for considering.
8fe0fb7 to
0bb8a23
Compare
0bb8a23 to
c907cbe
Compare
hmaarrfk
commented
Feb 7, 2025
Contributor
Author
|
No matter what, "simplifying" the code always causes the number of lines to increase sorry. |
almarklein
reviewed
Feb 7, 2025
almarklein
reviewed
Feb 8, 2025
Korijn
approved these changes
Feb 9, 2025
Contributor
Author
|
Thanks a bunch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to register blenders would remove a big 'non sactioned' customizations I have for PyGFX.
It would also allow more end user blender modes.
I know the blenders/rendering pipeline is being refactored. But this would really help in the meantime (after release 0.8.0 of course).
Thanks for considering.