Parse timeout value to BaseProxy and SequenceProxy#270
Parse timeout value to BaseProxy and SequenceProxy#270owenlittlejohns merged 5 commits intopydap:masterfrom
Conversation
|
@captainkirk99 sorry for bothering you, but could you give me some advice how things are done here when it comes to code improvement suggestions? Cheers! |
|
@owenlittlejohns I just remembered this PR and I am wondering if there is any chance that this could be merged. I am looking into resolving the conflicts against master right now. Since this is a timeout issue that likely only hits in on slow bandwidth connections and large queries I am also a little uncertain whether (and how) to add a test case here, and would only spend further time on this if you consider the change. |
|
@owenlittlejohns I updated the PR and added some simple tests to make sure timeouts are parsed accordingly into the respective proxies. Hope to hear back from you (or someone else that can assess this). |
|
@jgallagher59701 also pinging you on this one and would appreciate it if you could take a look. |
There was a problem hiding this comment.
The changes look good to me - I also kicked off the tests, which passed. I'll give @jgallagher59701 chance to weigh in, but I think this looks good. I also tested this locally, setting the timeout kwarg in pydap.client.open_url, and this change looks to be working as expected. Nice!
|
For reference, my test case: |
|
Many thanks for looking into this @owenlittlejohns |
|
Yes, I just looked over it and, @owenlittlejohns if you have tested it, then I'm happy to merge. As for a release to PyPI and Conda, sure lets do that so that we can stay in practice. |
|
Okay. I've merged this and I'll get cracking on the next |
For details see #269