Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Iss294 #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mikejmnez merged 57 commits into from
Mar 28, 2024
Merged

Iss294 #296

Mikejmnez merged 57 commits into from
Mar 28, 2024

Conversation

@Mikejmnez
Copy link
Collaborator

@Mikejmnez Mikejmnez commented Mar 21, 2024 •
edited
Loading

Addresses #294

- [x] sets micromamba to build tests in github workflows. This was turning into a bit of a project... left for later

  • includes environment files ci/environment.yml and docs/environment.yml to build conda envs for building/developing documentation and testing environment.
  • Fixes many of the broken links in the documentation.
  • Added an example using ERRDAP! .
  • Includes new section in the docs for how to contribute to the code (testing) and documentation.
  • Include myself in the list of contributors.
  • Add a readthedocs.yaml file per v2.
  • Include basic templates for opening issues and pull request (may improve them afterwards).
  • Included a dependabot.yml to assist on the github workflows to manage / update python-setup / python-coverage in the .github/workflows. For example, there is a deprecation warning about node16.js that can be addressed by updated the version of python-setup and coverage.
  • Adds a conda-badge to the README file so that the conda version of pydap is visible from github.
  • remove unnecessaary dependencies: Ordereddict is now imported directly from collections.
    - [x] Drops pyOpenSSL as dependency, as recommended by the pyOpenSSL project's readme... This is mentioned in Remove unused pyOpenSSL dependency #289 somehow pyopenssl even though not imported, is necessary for the second tests in tests_server_devel_ssl.py to pass (but only on mac OS!)

Mikejmnez added 30 commits March 15, 2024 15:12
@Mikejmnez
Adding myself to contributors
02144cf
@Mikejmnez
replace with maintained project #https://pypi.org/project/docopt-ng/
ba3e3b8
@Mikejmnez
up to date test environment
2af4c5a
@Mikejmnez
remove abandoned docopt with the maintained forked
3c29bc4
@Mikejmnez
remove req. packs. already being installed when installing pydap
a3a6420
@Mikejmnez
update README for install + conda badge
027ef14
@Mikejmnez
include scipy as an install requirement. It is used by default whenev…
3263b81 
…er `netCDF4` is not installed
@Mikejmnez
include basic conda installation / badge
1494fa6
@Mikejmnez
update working urls, and relevant data sources
53d5d27
@Mikejmnez
update code snippets and fix broken links
00f96ce
@Mikejmnez
fix broken links
e19d71f
@Mikejmnez
include mamba installation
00a4db5
@Mikejmnez
fix synthax
15cb040
@Mikejmnez
environment for building the documentation
6380864
@Mikejmnez
include how to make contributions to code
da872b6
@Mikejmnez
update documentations / broken links
0821e4e
@Mikejmnez
include how to install with mamba
838baf5
@Mikejmnez
include env file for ci installation
d6767ff
@Mikejmnez
include how to contribute to the documentation
f21cd5f
@Mikejmnez
finalizing docs
c41046b
@Mikejmnez
final adjust docs
5bcfae8
@Mikejmnez
make micromamba build tests from ci/env file
9393434
@Mikejmnez
remove setting a default
2c38e4d
@Mikejmnez
ignore _build in docs directory
d8541b3
@Mikejmnez
make clean docs build - shouldnt be tracked
73c095e
@Mikejmnez
set actions to v4
de13b5c
@Mikejmnez
fix indentation
9f88b04
@Mikejmnez
mamba does not like 3.x notation
6bf2a5f
@Mikejmnez
remove unused package dependencity, pydap uses OrderedDict from `co…
9cf1e99 
…llections`
@Mikejmnez
hd4 and hdf5 are installed by default - no need to run brew any…
9eaff7d 
…more
@Mikejmnez
Copy link
Collaborator Author

Mikejmnez commented Mar 24, 2024 •
edited
Loading

No changes. I think the test.opendap.org/opendap/hyrax/data/nc/ was slow or down when I got this PR running yesterday, and so a test kept failing due to some timeout error when trying to reach the server. Today, tests passed on my computer with no additional change and so I expect them to pass here as well.

@Mikejmnez
Copy link
Collaborator Author

Mikejmnez commented Mar 25, 2024

PR keeps getting stuck after running successfully the tests. Will close and re-open the PR per THIS somewhat old thread. I have tried many different things to trigger the PR.

@Mikejmnez Mikejmnez closed this Mar 25, 2024
@Mikejmnez Mikejmnez reopened this Mar 25, 2024
@Mikejmnez
Copy link
Collaborator Author

Mikejmnez commented Mar 27, 2024

OK - ready. Apologies for the extra commits: there was something going that I couldn't figure out in the "checks" that github has in place. All the tests were successful but there was one "check" that kept lingering for days and the only way figure it out what was going on was to push commits (local tests always passed).

jgallagher59701
jgallagher59701 approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@jgallagher59701 jgallagher59701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great.
When you merge this, please use the Squash option so that this will appear as a single commit, unless you think that one of the interior commits might need to be reverted later.
Thanks!

@Mikejmnez Mikejmnez merged commit 1cfd657 into pydap:master Mar 28, 2024
@Mikejmnez Mikejmnez mentioned this pull request Mar 28, 2024
Closed
7 tasks
@Mikejmnez Mikejmnez deleted the iss294 branch April 1, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgallagher59701 jgallagher59701 jgallagher59701 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mikejmnez @jgallagher59701