drop docopt-ng, beautifulsoup4, lxml and others as required dependencies #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jgallagher59701 this PR is ready for review! Notice that I was able in this PR to finally remove Python 3.9 :) |
jgallagher59701
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following Pull Request:
With regards to #354 - pydap now only has 3 required dependencies:
scipy,numpy>=2.0, andrequests. These are automatically installed with pydap doing:And so this PR defines an appropriate minimal-lightweight pydap pip-installation for running it as a client. Any other (optional) dependencies can be installed using [ ] installation when doing pip. For example:
This command install all required (optional) pydap and all optional python dependencies for running pydap as a server, along with python's netCDF4.
The arguments for the square-brackets, as well as their associated optional dependencies, are defined in the project.toml file.
With regards to Dropping Python 3.9 (#349) - I edited the branch protection rules for
main(findable under settings/branch). In it, it specified running checks for ubuntu and Python 3.9 asRequiredfor any PR, and that made it impossible to remove python 3.9 from testing. Removing that Protection rule for python 3.9 in ubuntu allows this PR to be merged.