Quick patchwork to parse TDS DAP4 responses #415
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick patchwork so that pydap CAN parse DAP4 responses from TDS. See #401
There are a couple of issues related to parsing DAP responses from a TDS. This PR solves:
a) Correctly split DMR from binary data in the response. There are very small differences in how the 2 servers split the dmr from the binary data:
Hyrax
TDS
DAP4 support within pydap has been written to accomodate Hyrax. The vary small difference between the two servers means that returning data from a TDS via DAP4 results in error.
With this PR, now there is no error but there is a "UserWarning" to inform users to use DAP2 protocol with TDS. The reason for that is this PR still does not fix another discrepancy between TDS and Hyrax servers. The discrepancy may be small, but relates to at least partially with how
endiannessis specified in the response.For example, when reading from this data_URL on Hyrax you CORRECTLY get:
The same
data_urlrunning on TDS gets you:The issue is NOT JUST endianness. And so for now passing a useful UserWarning is enough, while we spend some time working with the tds folks on resolving this issue.