-
Couldn't load subscription status.
- Fork 88
broaden dmr parser to allow multiple values on single attribute #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…h an attribute with multiple values
|
@jgallagher59701 ready for review |
|
actually - just realized that I am missing case 1 in #421 . Implementing this now. |
|
Done. Added plenty of testing and made sure all 4 cases (and combination of them) described in #406 are covered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but I think some more commentary will help us a year from now. ;-)
This is a draftThe following Pull Request:
on a local environment.
example
This is included in the testing
the last line returns the list for attribute
'attr'. All values, excep None, are Float32, associated with variable'x'of type int32