Named dim consolidate #507
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following Pull Request:
consolidate_metadatacheck for named dimensions #506. It adds another parameter that enables to check for maps in the case of named dimensions.This addresses a performance issue when accessing via
xarray+pydapocean velocity from OSCAR. For that datasetlatitudeandlongitudeare named, whereaslatandlonrespectively have the values (meaning one can request dap responses). In this scenario, xarray requestslatandloninstead oflatitudeandlongitude. The requests grow as 2*N, N being the number of URLS.This PR then enables caching for
lat,lonor any other similar Map, when theset_mapsis set toTrue(False by default).Example
For 100 urls ,
consolidate_metadatatakes ~40 secs. With that, the following takes 1 second:Notes
consolidate_metadataand create the xarray dataset directly. However, this is ~ 10x slower.