Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@scaramallion
Copy link
Member

@scaramallion scaramallion commented Nov 4, 2020

Describe the changes

Tasks

  • Unit tests added that reproduce the issue or prove feature is working
  • Fix or feature added
  • Documentation updated (if relevant)
  • Unit tests passing and overall coverage the same or better

@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #1255 into 2.1.X will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            2.1.X    #1255   +/-   ##
=======================================
  Coverage   95.15%   95.15%           
=======================================
  Files          57       57           
  Lines        9297     9297           
=======================================
  Hits         8847     8847           
  Misses        450      450           
Impacted Files Coverage Δ
pydicom/jsonrep.py 93.69% <ø> (ø)
pydicom/_version.py 100.00% <100.00%> (ø)
pydicom/filebase.py 97.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59be499...e71a14a. Read the comment docs.

@scaramallion scaramallion changed the title [WIP] Typing and JSON fixes [MRG] Typing and JSON fixes Nov 5, 2020
@darcymason darcymason merged commit 384b8be into pydicom:2.1.X Nov 5, 2020
@scaramallion scaramallion deleted the type-fixes branch November 5, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants