Implement a basic hetero sampler in the class #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…m/pyg-lib into vid_hetero_neigh_sampler
for more information, see https://pre-commit.ci
…m/pyg-lib into vid_hetero_neigh_sampler
rusty1s
approved these changes
Mar 27, 2025
Comment on lines
+181
to
+182
| if (edge_time_.has_value()) | ||
| TORCH_CHECK(seed_time.has_value(), "Seed time needs to be specified"); |
There was a problem hiding this comment.
and node_time_? Perhaps we can add a utility function such as is_temporal.
There was a problem hiding this comment.
The original implementation logic which I was following will just use node times from the graph if seed_time isn't given. I don't see a reason to deviate from the behaviour of hetero_neighbor_sample
Comment on lines
+197
to
+201
| phmap::flat_hash_map<node_type, size_t> num_nodes_dict; | ||
| for (const auto& k : edge_types_) { | ||
| const auto num_nodes = rowptr_.at(to_rel_type(k)).size(0) - 1; | ||
| num_nodes_dict[std::get<0>(k)] = num_nodes; | ||
| } |
There was a problem hiding this comment.
See my answer to the next comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a basic GraphSAGE sampler inside the
HeteroNeighborSampler.