Remove Python.h
#462
Merged
Remove Python.h
#462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes Python linkage from the build system, stripping out Python.h includes and the USE_PYTHON option, and updates relevant build scripts and documentation.
- Drop
-DUSE_PYTHONflag insetup.pyand remove Python find/link steps in CMake. - Remove Python headers and stub module init in
library.cpp. - Adjust Windows suffix logic and update changelog to note removed Python linking.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| setup.py | Removed -DUSE_PYTHON cmake argument |
| pyg_lib/csrc/library.cpp | Stripped out #include <Python.h> and Python init stub |
| CMakeLists.txt | Deleted USE_PYTHON option and Python linking; tweaked MSVC suffix |
| CHANGELOG.md | Added note for removed Python linking |
Comments suppressed due to low confidence (3)
pyg_lib/csrc/library.cpp:11
- [nitpick] This comment is outdated since
Python.his removed. Consider deleting or updating it to reflect the current codebase and avoid confusion.
// For PyMODINIT_FUNC to work, we need to include Python.h
pyg_lib/csrc/library.cpp:12
- The PyInit__C function signature no longer matches the expected Python module init signature. It should use
PyMODINIT_FUNC(returningPyObject*) or an equivalent to ensure the module can initialize correctly when Python support is restored or needed.
void* PyInit__C(void) {
CMakeLists.txt:156
- The
.pydsuffix is now applied for all MSVC builds, even when not building a Python extension. Restore theAND USE_PYTHONcondition to avoid incorrect artifact naming.
elseif (MSVC)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by pytorch/vision#8413.