Add neighbor sampler benchmark #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kgajdamo
commented
Aug 31, 2022
- Added neighbor sampler benchmark to pyg-lib.
- Benchmark measures performance for the neighbor_sample from pyg-lib as well as neighbor_sample from pytorch_sparse.
- Added argument "return_csc" to withDataset decorator to optionally return matrix in CSC format (for the purpose of pytorch_sparse neighbor sample).
|
Cool! How do the two implementations compare to each other? |
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
=======================================
Coverage 79.25% 79.25%
=======================================
Files 14 14
Lines 294 294
=======================================
Hits 233 233
Misses 61 61 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mananshah99
reviewed
Aug 31, 2022
@rusty1s Just like it is done in a subgraph benchmark, we print out the total duration of the neighbor_sample function first for pyg-lib and then for the pytorch_sparse. |
rusty1s
reviewed
Sep 1, 2022
rusty1s
approved these changes
Sep 1, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.