Reset segment_matmul feature granularity back to 1
#115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntial, even for shapes that don't require padding
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
=======================================
Coverage 89.18% 89.18%
=======================================
Files 16 16
Lines 416 416
=======================================
Hits 371 371
Misses 45 45 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
segment_matmul feature granularity back to 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In benchmarking found that the speedup of granularity 4 is inconsequential, even for shapes that don't require padding
considering the additional complexity that padding adds and that it will inevitably take time to pad, it seems better to just go back to single granularity.
The reason the #73 had such a speed boost was majority from the realization that the backward pass of other must still be for looped for optimal gpu utlization