(segment|grouped)_matmul improvements
#172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 93.14% 93.16% +0.02%
==========================================
Files 23 23
Lines 729 746 +17
==========================================
+ Hits 679 695 +16
- Misses 50 51 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
PyTorch stores shape information in `int64_t` variables, whereas MKL uses regular `int`. This means that tensor size can exceed the maximum value acceptable by MKL - in that case we need to use the ATen execution path
This file is generated automatically out of config.h.in during build time
09b0e61 to
28b9c24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added several fixes and improvements for
(segment|grouped)_matmul:int64_tvariables, whereas MKL uses regularint. This means that tensor size can exceed the maximum value acceptable by MKL - in that case we need to use the ATen execution path.config.hfile was removed and added to the .gitignore list - it is automatically generated during the build from theconfig.h.in.