Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@vid-koci
Copy link
Contributor

When sampling in a graph with timestamp, include the nodes that have the same timestamp as the seed nodes, instead of dropping them.

@vid-koci vid-koci requested review from ZenoTan and rusty1s and removed request for rusty1s January 25, 2023 15:33
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2023

Codecov Report

Merging #187 (7979108) into master (f980c23) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
+ Coverage   82.18%   82.29%   +0.11%     
==========================================
  Files          26       26              
  Lines         853      853              
==========================================
+ Hits          701      702       +1     
+ Misses        152      151       -1     
Impacted Files Coverage Δ
pyg_lib/csrc/sampler/cpu/neighbor_kernel.cpp 88.18% <100.00%> (+0.78%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s merged commit 354e85c into master Jan 25, 2023
@rusty1s rusty1s deleted the vid_neighbour_sampling branch January 25, 2023 16:45
rusty1s added a commit to pyg-team/pytorch_geometric that referenced this pull request Jan 26, 2023
Adjusts the code and docs for change
[187](pyg-team/pyg-lib#187) in pyg-lib. Temporal
sampling should now sample nodes with the same timestamp as the seed
nodes.

Co-authored-by: Matthias Fey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants