Update dist_neighbor_sample
#253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
==========================================
+ Coverage 79.61% 83.48% +3.86%
==========================================
Files 28 28
Lines 996 969 -27
==========================================
+ Hits 793 809 +16
+ Misses 203 160 -43
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rusty1s
added a commit
that referenced
this pull request
Sep 15, 2023
#254) This code belongs to the part of the whole distributed training for PyG. This PR is complementary to the [#246](#246). ##Descrption Perform global to local mappings using mapper and create (row, col) based on a sampled_nodes_with_duplicates and sampled_nbrs_per_node. **Other distributed PRs:** pytorch_geometric DistLoader: [#7869](pyg-team/pytorch_geometric#7869) pytorch_geometric DistSampler: [#7974](pyg-team/pytorch_geometric#7974) pyg-lib [MERGED]: [#246](#246) pyg-lib: [#252](#252) pyg-lib: [#253](#253) --------- Co-authored-by: Matthias Fey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code belongs to the part of the whole distributed training for PyG.
This PR is complementary to the #246 and introduces some updates.
What has been changed:
dist_hetero_neighbor_samplefunction (due to the fact, that distributed sampling have a loop over the layers in python, in case of hetero at the moment when we callneighbor_samplewe have only one edge type. So it becomes actually homo and we don't need thedist_hetero_neighbor_sampleand can usedist_neighbor_sampleinstead.)node,edge_ids,cummsum_sampled_nbrs_per_node.std::vector<int64_t> num_neighborsinput list intoint64_t one_hop_num.Added: