Thanks to visit codestin.com
Credit goes to github.com

Skip to content

pyg::subgraph #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 29, 2022
Merged

pyg::subgraph #31

merged 11 commits into from
Apr 29, 2022

Conversation

@rusty1s
Copy link
Member

@rusty1s rusty1s commented Apr 28, 2022

No description provided.

@rusty1s rusty1s self-assigned this Apr 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022 •
edited
Loading

Codecov Report

Merging #31 (e1267ea) into master (1e590f8) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #31   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         6    +2     
  Lines           79       105   +26     
=========================================
+ Hits            79       105   +26
Impacted Files Coverage Δ
pyg_lib/csrc/random/cpu/rand_engine.h 100.00% <ø> (ø)
pyg_lib/csrc/sampler/cpu/subgraph_kernel.cpp 100.00% <100.00%> (ø)
pyg_lib/csrc/sampler/subgraph.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e590f8...e1267ea. Read the comment docs.

@rusty1s rusty1s changed the title [WIP] pyg::subgraph pyg::subgraph Apr 29, 2022
@rusty1s rusty1s requested a review from yaoyaowd April 29, 2022 06:24
yaoyaowd
yaoyaowd approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@yaoyaowd yaoyaowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep thinking about how to reduce to_local_node look up from 2 to 1. But that doesn't block the code. Good work.

@rusty1s rusty1s merged commit a4da66c into master Apr 29, 2022
@rusty1s rusty1s deleted the subgraph branch April 29, 2022 09:15
@rusty1s rusty1s mentioned this pull request Apr 29, 2022
Open
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaoyaowd yaoyaowd yaoyaowd approved these changes

Assignees

@rusty1s rusty1s

Labels

0 - Priority P0 feature sampler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rusty1s @codecov-commenter @yaoyaowd