Thanks to visit codestin.com
Credit goes to github.com

Skip to content

clean up MGWR #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TaylorOshan merged 4 commits into from
May 22, 2018
Merged

clean up MGWR #11

TaylorOshan merged 4 commits into from
May 22, 2018

Conversation

@Ziqi-Li
Copy link
Member

@Ziqi-Li Ziqi-Li commented May 3, 2018

  1. Cleaned-up for MGWR. Removed some unnecessary calculations.
  2. Do we need the extra iteration in the MGWR.fit() even the backfitting has already converged and got results ready.
  3. Passing selector as a argument for MGWR.fit().

notebook for validation.

@Ziqi-Li Ziqi-Li requested a review from TaylorOshan May 3, 2018 03:38
@TaylorOshan TaylorOshan merged commit b1835e0 into pysal:master May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TaylorOshan TaylorOshan Awaiting requested review from TaylorOshan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ziqi-Li @TaylorOshan