Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jGaboardi
Copy link
Member

This PR updates the versioning implementation using versioner (xref #21), along with minor updates to doc links in README.md. Also, the .pre-commit-config.yml is added, which must be set up locally by devs individually.

@codecov
Copy link

codecov bot commented Jun 5, 2022

Codecov Report

Merging #39 (bbd831e) into master (68b77fb) will decrease coverage by 3.2%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #39     +/-   ##
========================================
- Coverage    98.2%   95.0%   -3.2%     
========================================
  Files          18       6     -12     
  Lines        1215     480    -735     
  Branches        0     111    +111     
========================================
- Hits         1193     456    -737     
+ Misses         22      14      -8     
- Partials        0      10     +10     
Impacted Files Coverage Δ
access/raam.py 86.2% <0.0%> (-3.8%) ⬇️
access/helpers.py 96.3% <0.0%> (-3.7%) ⬇️
access/access.py 95.8% <0.0%> (-2.1%) ⬇️
access/__init__.py
access/tests/util.py
access/tests/test_hospital_example.py
access/tests/test_weights.py
access/tests/test_floating_catchment_area.py
access/tests/test_datasets.py
access/tests/test_raam.py
... and 5 more

@jGaboardi
Copy link
Member Author

@JamesSaxon @martinfleis

I propose to update build_docs.yml so that it only builds when a fresh version tag is being pushed up. Thoughts? Shall I include it in this PR?

@jGaboardi jGaboardi changed the title [WIP] Update versioneer, etc Update versioneer, etc Jun 5, 2022
@jGaboardi jGaboardi self-assigned this Jun 5, 2022
@jGaboardi jGaboardi added the maint label Jun 5, 2022
@martinfleis
Copy link
Member

Shall I include it in this PR?

I'd leave it for another one.

@jGaboardi
Copy link
Member Author

Shall I include it in this PR?

I'd leave it for another one.

👍 This PR is ready for review then.

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jGaboardi
Copy link
Member Author

@JamesSaxon I'm going to and merging this. We can adjust/remove stuff later if it doesn't suit you (README badges, etc.).

@jGaboardi jGaboardi merged commit 9a28d7b into pysal:master Jun 6, 2022
@jGaboardi jGaboardi deleted the versioneer_etc branch June 6, 2022 22:18
@JamesSaxon
Copy link
Contributor

Thanks @jGaboardi, I appreciate all your work.

I'm happy to follow standards of the org for the infrastructure stuff & formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants