Thanks to visit codestin.com
Credit goes to github.com

Skip to content

resolve testing import failures -- #55 #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jGaboardi merged 1 commit into from
May 20, 2025
Merged

resolve testing import failures -- #55 #56

jGaboardi merged 1 commit into from
May 20, 2025

Conversation

@jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented May 20, 2025 •
edited
Loading

@jGaboardi
Copy link
Member Author

jGaboardi commented May 20, 2025

This failure appear to be varying behavior in an upstream dependency starting in the Python 3.9 environment

__________ TestEuclideanNeighbors.test_euclidean_neighbors_centroids ___________
[gw2] linux -- Python 3.10.17 /home/runner/micromamba/envs/access_310/bin/python3.10

self = <test_euclidean.TestEuclideanNeighbors testMethod=test_euclidean_neighbors_centroids>

    def test_euclidean_neighbors_centroids(self):
        self.model.create_euclidean_distance_neighbors(
            name="euclidian", threshold=2, centroid=True
        )
        actual1 = self.model.neighbor_cost_df["euclidian"][0]
        actual2 = self.model.neighbor_cost_df["euclidian"][2]
>       self.assertAlmostEqual(actual1, 1)
E       AssertionError: np.float64(0.0) != 1 within 7 places (np.float64(1.0) difference)

access/tests/test_euclidean.py:131: AssertionError

@jGaboardi jGaboardi mentioned this pull request May 20, 2025
Closed
@jGaboardi jGaboardi self-assigned this May 20, 2025
martinfleis
martinfleis approved these changes May 20, 2025
View reviewed changes
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual failure can be done as a follow-up.

@jGaboardi jGaboardi merged commit a931c48 into pysal:main May 20, 2025
2 of 6 checks passed
@jGaboardi jGaboardi deleted the GH55_fix_import_errors_in_tests branch May 20, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinfleis martinfleis martinfleis approved these changes

@knaaptime knaaptime Awaiting requested review from knaaptime

@JamesSaxon JamesSaxon Awaiting requested review from JamesSaxon

Assignees

@jGaboardi jGaboardi

Labels

maint

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'Access' from 'access' (unknown location)

2 participants

@jGaboardi @martinfleis