Fix Eucldean Neighbors Test #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix build docs further build docs revert this change -- leave it to JG
Member
hmmm. That Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #57
The test expectation was wrong; it seems like the ordering of the cross join simply changed between versions.
I have made the test more explicit, writing out the full expectation matrix for the two cases.
This made the assertion a little verbose, but I think it is more clear.
I see that build_docs.yml is broken, with
---at the top. Were you intending to suppress / comment these builds for now? Or can Ieave this to you @jGaboardi, or fix it? Presumably this is pretty close to what we want.