Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sjsrey
Copy link
Member

@sjsrey sjsrey commented Jul 11, 2020

No description provided.

@sjsrey sjsrey requested review from jGaboardi and knaaptime July 11, 2020 18:06
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2020

Codecov Report

Merging #135 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   77.61%   77.61%           
=======================================
  Files          25       25           
  Lines        3274     3274           
=======================================
  Hits         2541     2541           
  Misses        733      733           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2ad60d...258459a. Read the comment docs.

Copy link
Member

@jGaboardi jGaboardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the images seem not to have come through in the adbscan_berlin_example notebook.
  • link for esda.adbscan.ADBSCAN in esda/docs/api.html is not functional. Maybe we need to change the docsrc/api.rst entry to esda.ADBSCAN?

@jGaboardi jGaboardi added the docs label Jul 11, 2020
@sjsrey
Copy link
Member Author

sjsrey commented Jul 11, 2020

* link for `esda.adbscan.ADBSCAN` in `esda/docs/api.html` is not functional. Maybe we need to change the `docsrc/api.rst` entry to `esda.ADBSCAN`?

It's working locally for me here?

@sjsrey sjsrey requested a review from jGaboardi July 11, 2020 20:23
@jGaboardi
Copy link
Member

* link for `esda.adbscan.ADBSCAN` in `esda/docs/api.html` is not functional. Maybe we need to change the `docsrc/api.rst` entry to `esda.ADBSCAN`?

It's working locally for me here?

Yours is working locally for me now as well, but it wasn't before. When I checked the _images/ folder none of the .pngs were in there, but not they are. Maybe they just were hiding from the last commit.

Copy link
Member

@jGaboardi jGaboardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two ABSCAN issue are now resolved.

@sjsrey sjsrey merged commit bc9e0ae into pysal:master Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants