Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ljwolf
Copy link
Member

@ljwolf ljwolf commented Aug 3, 2020

This is a start at addressing #142, which we encountered during #116

@ljwolf ljwolf requested review from darribas and sjsrey August 3, 2020 10:40
@ljwolf
Copy link
Member Author

ljwolf commented Aug 3, 2020

If I recall correctly, we had a hard time getting numba>0.50.1 and the geospatial stack installed together from conda-forge. But, with issues in our current implementation arising with versions of numba below 0.50.0, we should try to encourage folks to upgrade their numba, otherwise we'll see breakage in local statistics for users with outdated numba.

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2020

Codecov Report

Merging #143 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #143   +/-   ##
=======================================
  Coverage   77.61%   77.61%           
=======================================
  Files          25       25           
  Lines        3274     3274           
=======================================
  Hits         2541     2541           
  Misses        733      733           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd4323a...d74fe32. Read the comment docs.

@darribas
Copy link
Member

Would <50 break? I think the only issue was that we could not pin random number generation inside numba-ized code so the tests results would vary and thus fail. Results would be correct though. No?

@ljwolf ljwolf merged commit 7e94624 into master Jan 20, 2021
@ljwolf
Copy link
Member Author

ljwolf commented Jan 20, 2021

Results would fail to compute. If numba is installed and numba fails to compile the function, then the results are not computed.

@jGaboardi jGaboardi deleted the numba-readme branch November 15, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants