Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ljwolf
Copy link
Member

@ljwolf ljwolf commented Sep 9, 2021

This follows pysal/libpysal#429 in using versioneer for this package versioning.

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2021

Codecov Report

Attention: Patch coverage is 41.17647% with 200 lines in your changes missing coverage. Please review.

Project coverage is 77.5%. Comparing base (33ae264) to head (496e4a5).

Files with missing lines Patch % Lines
esda/_version.py 40.7% 200 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #191     +/-   ##
========================================
- Coverage    80.2%   77.5%   -2.7%     
========================================
  Files          44      45      +1     
  Lines        4589    4927    +338     
========================================
+ Hits         3681    3819    +138     
- Misses        908    1108    +200     
Files with missing lines Coverage Δ
esda/__init__.py 100.0% <100.0%> (ø)
esda/_version.py 40.7% <40.7%> (ø)

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor issue with MANIFEST but otherwise it looks good.

Co-authored-by: Martin Fleischmann <[email protected]>
@jGaboardi jGaboardi merged commit 9dac8bd into pysal:master Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants